Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support py3.9/3.9 on workflows #1895

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Support py3.9/3.9 on workflows #1895

merged 3 commits into from
Apr 29, 2024

Conversation

mavaylon1
Copy link
Collaborator

@mavaylon1 mavaylon1 commented Apr 25, 2024 •
edited
Loading

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
The latest macos does not support python 3.8 or 3.9. We will use os 13 until we also deprecate 3.8 and 3.9.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

workflows

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (54b42b4) to head (dccb351).

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #1895   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          27       27           
  Lines        2619     2619           
  Branches      685      685           
=======================================
  Hits         2410     2410           
  Misses        139      139           
  Partials       70       70
Flag Coverage Δ
integration 72.81% <ø> (ø)
unit 83.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 marked this pull request as ready for review April 25, 2024 19:26
@mavaylon1 mavaylon1 enabled auto-merge (squash) April 29, 2024 00:10
@mavaylon1 mavaylon1 requested a review from stephprince April 29, 2024 00:10
@mavaylon1 mavaylon1 merged commit d7f5f26 into dev Apr 29, 2024
23 of 24 checks passed
@mavaylon1 mavaylon1 deleted the mac_os branch April 29, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephprince stephprince stephprince approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavaylon1 @stephprince